Skip to content

[CIR] Backport fixsing ShuffleDynamicOp maskbits logic #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

[CIR] Backport fixsing ShuffleDynamicOp maskbits logic #1649

merged 1 commit into from
May 30, 2025

Conversation

AmrDeveloper
Copy link
Member

Backport the calculation of maskbits in the lowering from N - 1 to NextPowerOf2(numElements - 1) - 1, similar to Clang CG.

Backport from #141411

bcardosolopes
bcardosolopes approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bcardosolopes bcardosolopes merged commit 04c46ba into llvm:main May 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmrDeveloper @bcardosolopes