[CIR] Fix RTTI mangling assertion with qualified types #2002
+154
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanza
requested review from
andykaylor,
bcardosolopes and
xlauko
as code owners
lanza
added a commit
that referenced
this pull request
Nov 22, 2025
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: 3c9ffe9 Pull-Request: #2002
This was referenced Nov 22, 2025
This was referenced Nov 22, 2025
lanza
added a commit
that referenced
this pull request
Nov 24, 2025
Fixes an assertion failure when creating RTTI descriptors for types with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI requires that RTTI descriptors be created for unqualified types only, but ClangIR was passing qualified types to the mangling function. The fix strips qualifiers in BuildTypeInfo before mangling, matching the behavior of traditional CodeGen. Also strips qualifiers when getting RTTI descriptors for dynamic_cast operands, consistent with CodeGen's implementation. This fixes std::regex usage and other cases where qualified types are used with typeid or dynamic_cast. ghstack-source-id: e18ff76 Pull-Request: #2002
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes an assertion failure when creating RTTI descriptors for types
with top-level qualifiers (const, volatile, etc.). The Itanium C++ ABI
requires that RTTI descriptors be created for unqualified types only,
but ClangIR was passing qualified types to the mangling function.
The fix strips qualifiers in BuildTypeInfo before mangling, matching
the behavior of traditional CodeGen. Also strips qualifiers when
getting RTTI descriptors for dynamic_cast operands, consistent with
CodeGen's implementation.
This fixes std::regex usage and other cases where qualified types
are used with typeid or dynamic_cast.