[CIR][AMDGPU] Add basic ABI implementation of AMDGPU for CIR to LLVM #2078
+274
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skc7
force-pushed
the
skc7/cir_amdgpu_p2_abi
branch
2 times, most recently
from
5f0d82d to
4f4637c
Compare
skc7
changed the title
skc7
force-pushed
the
skc7/cir_amdgpu_p2_abi
branch
from
4f4637c to
616b450
Compare
skc7
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ABI lowering for AMDGPU for simple types.
LowerFunction::getEvaluationKind has been updated with more scalar types, since it fails with tests under HIP with this PR.
Pre-requisite PR: #2084