Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llvm-driver to the list of toolchain tools #123083

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

Andarwinux
Copy link
Contributor

If LLVM_TOOL_LLVM_DRIVER_BUILD is enabled, make sure LLVM_TOOLCHAIN_TOOLS includes llvm-driver, otherwise with LLVM_INSTALL_TOOLCHAIN_ONLY will install an invalid toolchain

@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Jan 15, 2025
Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@Andarwinux Andarwinux force-pushed the driver branch 3 times, most recently from fe61483 to 7fa35d7 Compare January 16, 2025 17:59
@Andarwinux
Copy link
Contributor Author

Hi @chandlerc, could you take a look at this? You are listed as the maintainer for cmake.

@chandlerc
Copy link
Member

Hi @chandlerc, could you take a look at this? You are listed as the maintainer for cmake.

I've not been active forever, and they just updated to fresh maintainers I believe.

@nikic nikic requested review from llvm-beanz and petrhosek January 18, 2025 09:32
@Andarwinux
Copy link
Contributor Author

ping

If LLVM_TOOL_LLVM_DRIVER_BUILD is enabled, make sure LLVM_TOOLCHAIN_TOOLS includes llvm-driver, otherwise with LLVM_INSTALL_TOOLCHAIN_ONLY will install an invalid toolchain
@Andarwinux
Copy link
Contributor Author

Hi, can we merge this now?

@petrhosek petrhosek merged commit ab6d41e into llvm:main Jan 29, 2025
8 checks passed
@Andarwinux Andarwinux deleted the driver branch January 29, 2025 07:58
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jan 31, 2025

LLVM Buildbot has detected a new failure on builder lld-x86_64-win running on as-worker-93 while building llvm at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2199

Here is the relevant piece of the build log for the reference
Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/38/87' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-4304-38-87.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=87 GTEST_SHARD_INDEX=38 C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe
--

Script:
--
C:\a\lld-x86_64-win\build\unittests\Support\.\SupportTests.exe --gtest_filter=ProgramEnvTest.CreateProcessLongPath
--
C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(160): error: Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp(163): error: fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied



C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:160
Expected equality of these values:
  0
  RC
    Which is: -2

C:\a\lld-x86_64-win\llvm-project\llvm\unittests\Support\ProgramTest.cpp:163
fs::remove(Twine(LongPath)): did not return errc::success.
error number: 13
error message: permission denied




********************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants