Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polly: Fix files that contain Python 3 SyntaxErrors #124424

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cclauss
Copy link

@cclauss cclauss commented Jan 25, 2025

These changes were originally in:

They are moved here to enable a focused review by polly authors: @tobiasgrosser, @Meinersbur


The polly/lib/External/isl/imath/tools/findthreshold.py changes were already made upstream:
https://github.com/creachadair/imath/blob/main/tools/findthreshold.py

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@cclauss cclauss force-pushed the polly-fix-python-syntax-errors branch from e0556a0 to 11c7a68 Compare January 25, 2025 20:35
@Meinersbur
Copy link
Member

Meinersbur commented Jan 26, 2025

Thanks for the PR. These are python2 source, and only syntax errors in Python3 (please fix the title accordingly).

threshold.py has been updated at creachadair/imath@03fc662. Changes in this repository will be overwritten the next time update-isl.py. It will pick the revision from https://repo.or.cz/isl.git/history/HEAD:/imath. To update that, contact the maintainer at [email protected]. The script is not used within Polly, hence I would rather not make changes here.

The other two need to complete update Python3. Did you actually execute these scripts to confirm they work with Python3.

@cclauss cclauss changed the title polly: Fix three Python files that contain SyntaxErrors polly: Fix files that contain Python 3 SyntaxErrors Jan 26, 2025
@cclauss
Copy link
Author

cclauss commented Jan 26, 2025

I modified the title as requested.

https://repo.or.cz/isl.git/history/HEAD:/imath returns a 500 error and poking around in
https://repo.or.cz/isl.git I am unable to find imath. I probably misunderstand this site.


This pull request was not attempting to complete the port to Python 3. As recommended in the following locations, the pull request was only focused on stage-1 changes:

Proving that Python 2 tests still run successfully without Python 3 syntax errors is a gate before porting to Python 3. The upstream imath has already made stage 2 modifications by removing .iteritems() and .xrange() which changes Python 2 behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants