[TORCH] Modified fx_importer to support hop_while_loop #4338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keshav Vinayak Jha <[email protected]>
keshavvinayak01
changed the title
Signed-off-by: Keshav Vinayak Jha <[email protected]>
Signed-off-by: Keshav Vinayak Jha <[email protected]>
Signed-off-by: Keshav Vinayak Jha <[email protected]>
…teless_graph Signed-off-by: Keshav Vinayak Jha <[email protected]>
keshavvinayak01
changed the title
Groverkss
requested review from
Groverkss,
penguin-wwy,
rsuderman,
stellaraccident and
zjgarvey
and removed request for
stellaraccident
|
I'm working on resolving ci issues right now. Once that lands, I'll ping here to have you sync your branch with main and review. |
Sounds good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for emitting graphs for Pytorch HOPs, beginning with
torch._higher_order_ops.while_loop.The proposed change is to modify the
import_programto call function_import_all_child_modules, which recursively imports the stateless graph for all the children modules.Since HOP operator graphs are stateless graphs with no mutation, it is correct to import them as stateless graphs, although the method
import_stateless_graphis marked as "deprecated".