Skip to content

Conversation

@lmignon
Copy link
Owner

@lmignon lmignon commented Apr 16, 2025

This is required to avoid a bug in some pydantic methods when a instance is checked against its own type and the result was wrongly returned as False

see lmignon/extendable#18

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.59%. Comparing base (634cf50) to head (7f6943a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   33.50%   36.59%   +3.09%     
==========================================
  Files           6        6              
  Lines         194      194              
  Branches       48       37      -11     
==========================================
+ Hits           65       71       +6     
+ Misses        120      115       -5     
+ Partials        9        8       -1     
Flag Coverage Δ
unittests 36.59% <ø> (+3.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lmignon lmignon force-pushed the master-check-union branch from caa6e0d to e306472 Compare April 16, 2025 15:47
This is required to avoid a bug in some pydantic methods when a instance is checked against its own type and the result was wrongly returned as False

see lmignon/extendable#18
@lmignon lmignon force-pushed the master-check-union branch from e306472 to 7f6943a Compare April 16, 2025 15:49
@lmignon lmignon marked this pull request as ready for review April 16, 2025 15:51
@lmignon lmignon changed the title [CI] fix pre-commit, drop suppport for py3.7 and add support for py3.13 Force the use of extendable>=1.3.0 Apr 16, 2025
@lmignon lmignon merged commit b0b8fe3 into master Apr 16, 2025
9 checks passed
@lmignon lmignon deleted the master-check-union branch April 16, 2025 15:51
@lmignon lmignon restored the master-check-union branch April 16, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants