Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ test: add unit test for src/services/aiModel/server.ts #6090

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

gru-agent[bot]
Copy link
Contributor

@gru-agent gru-agent bot commented Feb 13, 2025

Trigger Info

Trigger Type Triggered By Source File Assignment
Push arvinxx src/services/aiModel/server.ts Detail

Summary

This PR introduces unit tests for the ServerService class, ensuring the correctness of its methods that interact with the lambdaClient for AI model management. The following functionalities are covered:

  • AI Model Creation: Verifies the createAiModel method calls the appropriate client mutation with the correct parameters.

  • Fetching AI Provider Model List: Tests the getAiProviderModelList method to ensure it queries the client with the correct provider ID.

  • Fetching AI Model by ID: Confirms the getAiModelById method queries the client with the correct model ID.

  • Toggling Model Enabled State: Validates the toggleModelEnabled method calls the client mutation with the correct parameters.

  • Updating AI Model: Ensures the updateAiModel method sends the correct payload to the client mutation.

  • Batch Updating AI Models: Tests the batchUpdateAiModels method for proper client interaction with a list of models.

  • Batch Toggling AI Models: Verifies the batchToggleAiModels method toggles multiple models' states correctly.

  • Clearing Models by Provider: Confirms the clearModelsByProvider method interacts with the client to clear models for a specific provider.

  • Clearing Remote Models: Ensures the clearRemoteModels method clears remote models for a given provider.

  • Updating AI Model Order: Validates the updateAiModelOrder method updates the sort order of models correctly.

  • Deleting AI Model: Tests the deleteAiModel method to ensure it removes a model using the correct parameters.

Mocks for lambdaClient are used to isolate the tests, and all methods are verified to call the expected client functions with the correct arguments. This ensures robust coverage for the ServerService class.

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Tip

You can @gru-agent rebase to rebase the PR.

Tip

You can @gru-agent redo to reset or rebase before redoing the PR.

Tip

To modify the test code yourself, click here Edit Test Code

@gru-agent gru-agent bot requested a review from arvinxx February 13, 2025 06:24
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 13, 2025
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
lobe-chat-preview ⬜️ Ignored (Inspect) Feb 13, 2025 6:24am

@lobehubbot
Copy link
Member

👍 @gru-agent[bot]

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (257fda1) to head (3f364ef).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6090      +/-   ##
==========================================
+ Coverage   92.43%   92.47%   +0.04%     
==========================================
  Files         661      661              
  Lines       60005    60005              
  Branches     3022     4410    +1388     
==========================================
+ Hits        55463    55488      +25     
+ Misses       4542     4517      -25     
Flag Coverage Δ
app 92.47% <ø> (+0.04%) ⬆️
server 97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx merged commit a75100f into main Feb 13, 2025
16 checks passed
@arvinxx arvinxx deleted the testgru-src-services-aiModel-server.ts-1739427856465 branch February 13, 2025 06:57
@lobehubbot
Copy link
Member

❤️ Great PR @gru-agent[bot] ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.53.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

AirboZH pushed a commit to yuanze-dev/lobe-chat that referenced this pull request Feb 14, 2025
…obehub#6090)

Co-authored-by: gru-agent[bot] <185149714+gru-agent[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants