Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ test: add unit test for src/store/aiInfra/slices/aiModel/selectors.ts #6113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gru-agent[bot]
Copy link
Contributor

@gru-agent gru-agent bot commented Feb 13, 2025

Trigger Info

Trigger Type Triggered By Source File Assignment
Push arvinxx src/store/aiInfra/slices/aiModel/selectors.ts Detail

Summary

This PR introduces comprehensive unit tests for the aiModelSelectors module, ensuring robust validation of its functionality. The tests cover a wide range of scenarios and selector methods, including:

  • Model Filtering and Categorization:

    • aiProviderChatModelListIds: Verifies retrieval of chat-type model IDs.

    • enabledAiProviderModelList and disabledAiProviderModelList: Validate separation of enabled and disabled models.

    • filteredAiProviderModelList: Tests filtering models based on search keywords.

    • totalAiProviderModelList and isEmptyAiProviderModelList: Check total count and emptiness of the model list.

  • Remote Model Detection:

    • hasRemoteModels: Confirms the presence of remote models in the list.
  • Model State Checks:

    • isModelEnabled and isModelLoading: Validate whether a model is enabled or currently loading.
  • Model Retrieval:

    • getAiModelById: Ensures correct retrieval of models by their ID.
  • Capability Checks:

    • isModelSupportToolUse, isModelSupportVision, and isModelSupportReasoning: Verify model support for specific capabilities.
  • Context Window Tokens:

    • isModelHasContextWindowToken and modelContextWindowTokens: Validate the presence and retrieval of context window tokens for models.

The tests utilize a mock state to simulate various scenarios, ensuring the selectors behave as expected under different conditions. This addition significantly enhances the reliability and maintainability of the aiModelSelectors module.

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Tip

You can @gru-agent rebase to rebase the PR.

Tip

You can @gru-agent redo to reset or rebase before redoing the PR.

Tip

To modify the test code yourself, click here Edit Test Code

@gru-agent gru-agent bot requested a review from arvinxx February 13, 2025 15:20
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
lobe-chat-database ⬜️ Ignored (Inspect) Feb 13, 2025 3:22pm
lobe-chat-preview ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 3:22pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 13, 2025
@lobehubbot
Copy link
Member

👍 @gru-agent[bot]

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (8ed48c9) to head (25dbab5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6113      +/-   ##
==========================================
+ Coverage   92.47%   92.53%   +0.06%     
==========================================
  Files         661      661              
  Lines       60008    60008              
  Branches     2824     3031     +207     
==========================================
+ Hits        55490    55526      +36     
+ Misses       4518     4482      -36     
Flag Coverage Δ
app 92.53% <ø> (+0.06%) ⬆️
server 97.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants