Skip to content

Conversation

@Innei
Copy link
Member

@Innei Innei commented Jan 16, 2026

Summary

  • Update @base-ui/react from 1.0.0 to 1.1.0
  • Adjust Popover styles to accommodate new version changes

Changes

  • package.json: Bump @base-ui/react version
  • src/Popover/style.ts: Update Popover styling

Summary by Sourcery

Update the Base UI React dependency and adjust Popover layout styling to align with the new version.

Enhancements:

  • Adjust Popover dimensions to respect the available width while using the computed positioner width.

Build:

  • Bump @base-ui/react dependency from 1.0.0 to 1.1.0.

…yles

- Upgraded the @base-ui/react dependency to version 1.1.0 for improved features and fixes.
- Modified Popover component styles to set width to var(--positioner-width) and max-width to var(--available-width) for better responsiveness.

Signed-off-by: Innei <[email protected]>
@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lobe-ui Ready Ready Preview, Comment Jan 16, 2026 3:50pm

Request Review

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 16, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps @base-ui/react from 1.0.0 to 1.1.0 and adjusts Popover layout styling to match the new version’s expectations for sizing behavior.

Flow diagram for updated Popover sizing behavior

flowchart TD
  A[Popover renders] --> B[Compute positioner_width]
  A --> C[Compute available_width]

  B --> D[Set width to positioner_width]
  C --> E[Set max_width to available_width]

  D --> F[Browser lays out Popover]
  E --> F

  F --> G{Is positioner_width > available_width?}
  G -- Yes --> H[Popover width constrained to available_width]
  G -- No --> I[Popover width equals positioner_width]
Loading

File-Level Changes

Change Details Files
Upgrade @base-ui/react dependency to version 1.1.0.
  • Update the @base-ui/react version string from 1.0.0 to 1.1.0 in the dependencies section.
  • Keep all other dependency versions unchanged.
package.json
Adjust Popover sizing styles to align with the new Base UI behavior.
  • Replace the combined min() width expression with a fixed width based on the positioner width.
  • Introduce a max-width constraint tied to the available width to preserve previous bounding behavior.
  • Keep other Popover styles and layout rules as-is.
src/Popover/style.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lobehubbot
Copy link
Member

👍 @Innei


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@gru-agent
Copy link
Contributor

gru-agent bot commented Jan 16, 2026

TestGru Assignment

Summary

Link CommitId Status Reason
Detail d550802 🚫 Skipped No files need to be tested {"package.json":"File path does not match include patterns.","src/Popover/style.ts":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 16, 2026

Open in StackBlitz

npm i https://pkg.pr.new/lobehub/lobe-ui/@lobehub/ui@454

commit: d550802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants