improve Assignment operation #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutierMat
commented
May 30, 2025
| @@ -4,8 +4,8 @@ | |||
|
|
|||
|
|
|||
| setup( | |||
| name="airspeed-ext", | |||
| version="0.6.8", | |||
| name="airspeed_ext", | |||
There was a problem hiding this comment.
I received a notice from PyPi after release the last package that we need to conform to PEP 625. My understanding is that this will solve the issue and won't have any side effects as far as installing and using the package.
bentsku
approved these changes
May 30, 2025
There was a problem hiding this comment.
LGTM, this is neat 👍 it makes much better use of the internal, nice find! This is also help support the case in the comment with set($one.two().three = something), with a "function call term"!
And now the Assignment still looks pretty similar to before, thanks to that, and remove the old .split("."). Awesome 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a follow up to #21. I wasn't super satisfied with the solution I found as it seemed to dangerously rely on a quasi-impossible to read regex and a big match/case.
The changes in this pr are utilizing the tools of airspeed a lot better and remove the responsibility of knowing each possible terms from
Assignmentand allow us to debug and add new terms if required in the future with more ease.