Skip to content

Fix OffsetCurve simplifyFactor parameter handling #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Fix OffsetCurve simplifyFactor parameter handling #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/core/src/main/java/org/locationtech/jts/operation/buffer/OffsetCurve.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ public OffsetCurve(Geometry geom, double distance, BufferParameters bufParams) {
bufferParams.setQuadrantSegments(quadSegs);
bufferParams.setJoinStyle(bufParams.getJoinStyle());
bufferParams.setMitreLimit(bufParams.getMitreLimit());
bufferParams.setSimplifyFactor(bufParams.getSimplifyFactor());
}
}

Expand Down
24 changes: 24 additions & 0 deletions modules/core/src/test/java/org/locationtech/jts/operation/buffer/OffsetCurveTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,18 @@ public void testPolygonJoinMitre() {
);

}

//---------------------------------------

// see https://github.com/locationtech/jts/issues/1147
public void testSimplifyFactor() {
checkOffsetCurveSimplify("LINESTRING (-74.10825983114643 205.2512862651522, -61.59032155710979 183.66416102497575, -56.17516937041343 177.39645645603244, -45.87664216572637 163.28009296700202, -32.80606824944878 140.06145723770865)",
-70, 0.0001,
"LINESTRING (-134.66360133032907 170.13646580544648, -122.14566305629245 148.54934056527003, -114.55900733787851 137.9004382015626, -111.02744383471095 133.81287132602836, -104.85483126202604 125.3519680316891, -93.80502418590495 105.72303306503763)",
0.00001);
}


//=======================================

private static final double EQUALS_TOL = 0.05;
Expand Down Expand Up @@ -450,4 +462,16 @@ private void checkOffsetCurve(String wkt, double distance,
checkEqual(expected, result, tolerance);
}

private void checkOffsetCurveSimplify(String wkt,
double distance, double simplifyFactor,
String wktExpected, double tolerance) {
Geometry geom = read(wkt);
BufferParameters params = new BufferParameters();
params.setSimplifyFactor(simplifyFactor);
OffsetCurve oc = new OffsetCurve(geom, distance, params);
Geometry result = oc.getCurve();

Geometry expected = read(wktExpected);
checkEqual(expected, result, tolerance);
}
}