Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Updated validator to 0.20 #1199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DenuxPlays
Copy link
Contributor

With validator 0.20 non 'static str can be used in ValidationErrors because it now uses Cow<'static, str>.

A nice thing to have now.

I haven't opened an issue so if this isn't wanted just close it.

@DenuxPlays DenuxPlays force-pushed the chore/update-validator branch from f1f8ab7 to e0dd1b7 Compare January 20, 2025 13:43
@DenuxPlays DenuxPlays changed the title [BREAKING] Updated validator [BREAKING] Updated validator to 0.20 Jan 20, 2025
@DenuxPlays
Copy link
Contributor Author

Going to fix ci later

@DenuxPlays
Copy link
Contributor Author

Windows test fails because of some type of sscache error:
image

I think the deployment fails because it uses the loco-rs crate that is currently on crates.io which does not yet support validator 0.20 right?

@kaplanelad
Copy link
Contributor

working now

@DenuxPlays DenuxPlays force-pushed the chore/update-validator branch from 0c57af7 to 2121480 Compare January 21, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants