Skip to content

Redis atomic job queue #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Redis atomic job queue #1464

wants to merge 5 commits into from

Conversation

kaplanelad
Copy link
Contributor

No description provided.

@kaplanelad
Copy link
Contributor Author

Hey @DenuxPlays and @jtwaleson,

Following up on our discussion in #1462 and the related PR: #1384 — I've fixed the positional issue in the Redis queue implementation.

Please test this branch with a Loco app and help verify the full Redis queue flow.

Specifically, please check:

  • End-to-end queue behavior in your app
  • Enqueueing, processing, and retry logic
  • Any edge cases or unusual behavior
  • Any other scenarios you think are worth testing

If you find any issues, feel free to either push a fix directly to my PR or comment here with a description and (if possible) steps to reproduce it

Thanks!

@DenuxPlays
Copy link
Contributor

Hey,

Haven't noticed anything but I am not done testing

Just wanted to say that we should probably Release an RC asking more to Test their application to cover Some edge cases we probably don't think about

@kaplanelad
Copy link
Contributor Author

Thanks, @DenuxPlays! Looking forward to your response once you're done testing.

@DenuxPlays
Copy link
Contributor

Hey,

sorry for the delay but I've tested it.

I hadn't had any issues with atomcity so this approach should work in production (I would still release an rc to widen our test cases).
I've noticed an increased redis CPU usage compared to the old implementation but nothing drastically. It was so minimal but it may also be just some test fluctuations. (less then 0.2% but consistent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants