Fix compilation with clang (#93)

Fix compilation with clang for the following packages:
- global_planner_tests
- nav_grid_iterators

Author: Rayman

global_planner_tests/src/heatmap_node.cpp

@@ -117,7 +117,7 @@ int main(int argc, char** argv)
         failures[i] += 1;
         failures[j] += 1;
       }
-      if (!ros::ok()) return false;
+      if (!ros::ok()) return EXIT_FAILURE;
     }
   }
 
@@ -152,5 +152,5 @@ int main(int argc, char** argv)
   }
 
   ROS_INFO("%d/%d valid plans found.", passing_plans, total_plans);
-  return 0;
+  return EXIT_SUCCESS;
 }

global_planner_tests/src/many_map_test_suite.cpp

@@ -73,7 +73,7 @@ bool many_map_test_suite(nav_core2::GlobalPlanner& planner, TFListenerPtr tf,
   bool passes_all = true;
 
   // Check all the Full Coverage Maps
-  for (const std::string base_filename : config["full_coverage_maps"].as<std::vector<std::string> >())
+  for (const auto& base_filename : config["full_coverage_maps"].as<std::vector<std::string> >())
   {
     std::string map_filename = prefix + base_filename;
     ROS_INFO("Testing full coverage map \"%s\"", map_filename.c_str());
@@ -86,7 +86,7 @@ bool many_map_test_suite(nav_core2::GlobalPlanner& planner, TFListenerPtr tf,
   }
 
   // Check all the No Coverage Maps
-  for (const std::string base_filename : config["no_coverage_maps"].as<std::vector<std::string> >())
+  for (const auto& base_filename : config["no_coverage_maps"].as<std::vector<std::string> >())
   {
     std::string map_filename = prefix + base_filename;
     ROS_INFO("Testing no coverage map \"%s\"", map_filename.c_str());

nav_grid_iterators/include/nav_grid_iterators/line/abstract_line_iterator.h

@@ -53,6 +53,11 @@ class AbstractLineIterator
    */
   AbstractLineIterator() {}
 
+  /**
+   * @brief Public Destructor
+   */
+  virtual ~AbstractLineIterator() = default;
+
   /**
    * @brief Dereference the iterator
    * @return the index to which the iterator is pointing.