Fallback to check for Toml without tool.locust heading for Issue#3225 #3242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
Collaborator
|
Not sure what this really does, but if you can fix the linting and test issues I'll have a look! |
Author
|
It looked like the documentation has examples both with and without a toml section called tool.locust, but in the ticket it is referencing the a configuration without tool.locust section. It seems like it wasn't working properly without the tool.locust section in the config file. It I tried to make it check for a file without a tool.locust config file |
Collaborator
|
Can you add a test case that this change fixes? |
Author
|
I added a test case |
Author
|
I don't know if this makes a difference, but all checks pass |
Collaborator
|
The test you added passes even without the code change. I did make a change in the area fixing another issue though, maybe that also sorted it? #3257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.