Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add support for podman credentials #1592

Conversation

pascalbreuninger
Copy link
Member

@pascalbreuninger pascalbreuninger commented Jan 24, 2025

Podman and other container engines store their auth config in a
different location than the default docker one.

  • docker: $HOME/.docker/config.json
  • podman: $HOME/.config/containers/auth.json

DevPod now tries to collect credentials from both ecosystem

solves #1572

@pascalbreuninger pascalbreuninger requested a review from a team January 24, 2025 13:52
@pascalbreuninger pascalbreuninger force-pushed the feat/POD-1266-support-podman-credentials branch 2 times, most recently from 752ece3 to ebf842d Compare January 24, 2025 14:06
Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger force-pushed the feat/POD-1266-support-podman-credentials branch 2 times, most recently from 19f32ac to d6eff57 Compare January 24, 2025 14:32
Podman and other container engines store their auth config in a
different location than the default docker one.
- docker: $HOME/.docker/config.json
- podman: $HOME/.config/containers/auth.json

DevPod now tries to collect credentials from both ecosystem
@pascalbreuninger pascalbreuninger force-pushed the feat/POD-1266-support-podman-credentials branch from d6eff57 to 457e504 Compare January 24, 2025 15:05
@pascalbreuninger pascalbreuninger merged commit 82b30ec into loft-sh:main Jan 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants