feat: Update file cache to use markdown instead of json

[logancyang]

• Added user_id to BrevilabsClient for backend rate limiting.
• Updated FileCache to support markdown file format and migrate legacy JSON cache files.
• Improved cache management by ensuring both markdown and legacy files are handled appropriately during read and write operations.

[logancyang]

bugbot run

[logancyang]

bugbot run

[logancyang]

bugbot run

[logancyang]

bugbot run

[logancyang]

bugbot run

[logancyang]

bugbot run

[cursor]

Bug: FileCache JSON Handling Fails

The FileCache's get method, when reading .md cache files, introduces type safety and data integrity issues:

• Incorrect JSON handling: The heuristic for detecting JSON content is flawed. It fails to parse JSON-serialized primitive types (e.g., numbers, booleans), which are stored as strings but retrieved as plain strings. Conversely, it incorrectly parses string content that coincidentally resembles JSON, returning an object/array instead of the original string.
• Unsafe type casting: If JSON parsing fails or isn't attempted, the string content read from the file is unsafely cast directly to the generic type T, leading to runtime type mismatches when T is not string.
• Inconsistent content handling: The JSON detection uses trimmed content, but the subsequent parsing uses untrimmed content.

src/cache/fileCache.ts#L61-L77

obsidian-copilot/src/cache/fileCache.ts

Lines 61 to 77 in c220e9a

	// Try to parse as JSON first (for non-string types that were serialized)
	const trimmedContent = cacheContent.trim();
	if (
	(trimmedContent.startsWith("{") && trimmedContent.endsWith("}")) ||
	(trimmedContent.startsWith("[") && trimmedContent.endsWith("]"))
	) {
	try {
	parsedContent = JSON.parse(cacheContent);
	} catch {
	// JSON parsing failed, treat as string content
	parsedContent = cacheContent as T;
	}
	} else {
	// Plain text content (primary case for markdown)
	parsedContent = cacheContent as T;
	}

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎