generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 407
Add Projects rate limit UI change #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
logancyang
commented
Jul 3, 2025
- Add rate limit info to tooltip
- Add a notice when rate limit is reached
- Added checks for rate limit errors in ProjectManager and ChatControls, re-throwing errors when detected. - Introduced a method in Docs4LLMParser to show user-friendly notices for rate limit exceedances, limiting notifications to once per minute. - Updated error logging to use a centralized logging function for consistency.
bugbot run |
- Updated error checks in ProjectManager and ChatControls to include status code 429 for better rate limit detection. - Ensured that errors are re-thrown when rate limits are exceeded, maintaining consistent error handling across components.
bugbot run |
- Introduced a centralized utility function `isRateLimitError` to streamline rate limit error detection in ProjectManager, ChatControls, and Docs4LLMParser. - Removed redundant error checking logic from multiple locations, enhancing code maintainability. - Added a new utility function `extractRetryTime` for better handling of retry time extraction from error messages.
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ BugBot reviewed your changes and found no bugs!
Was this report helpful? Give feedback by reacting with 👍 or 👎
Merged
wenzhengjiang
pushed a commit
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.