Sort custom prompt list by recency #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logancyang
reviewed
Sep 23, 2024
| // Clean up promptUsageTimestamps | ||
| this.usageStrategy?.removeUnusedPrompts(prompts.map((prompt) => prompt.title)).save(); | ||
|
|
||
| console.log(this.settings.promptUsageTimestamps); |
logancyang
reviewed
Sep 23, 2024
| @@ -0,0 +1,53 @@ | |||
| import { CopilotSettings } from "@/settings/SettingsPage"; | |||
There was a problem hiding this comment.
Nit: For consistency can we name this file promptUsageStrategy.ts without the capitalization.
|
@Emt-lin Thank you so much for the PR! Generally lgtm, just some nits. Btw, you can use |
|
Merging now and will address the nits myself in the next PR. |
ok, Thank you for the reminder. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #638