Skip to content

Added ability to tag saved conversations#659

Merged
logancyang merged 2 commits intologancyang:masterfrom
logicsec:master
Sep 19, 2024
Merged

Added ability to tag saved conversations#659
logancyang merged 2 commits intologancyang:masterfrom
logicsec:master

Conversation

@logicsec
Copy link
Contributor

Purpose
This pull request adds the ability to tag conversations within Obsidian Copilot, allowing for easier referencing and analysis using Dataview.

Motivation:
Currently, Obsidian Copilot doesn't offer a way to tag conversations, making it difficult to organize and retrieve specific conversations for analysis using Dataview.

This feature would enable users to:

  • Categorize conversations: Tag conversations based on topics, projects, or other relevant criteria.
  • Filter conversations: Use Dataview queries to retrieve conversations based on specific tags.
  • Analyze conversations: Gain insights from tagged conversations by using Dataview's powerful analysis capabilities.

Changes:

  • Added a new settings called Default Conversation Tag which defaults to ai-conversation.
  • Updated SettingsPage.tsc CopilotSettings interface to reference the new defaultTag string
  • Updated Chat.tsx to reference the new setting
  • Updated GeneralSettings.tsx to include new TextComponent

googleApiKey: string;
openRouterAiApiKey: string;
defaultModelKey: string;
defaultTag: string;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about defaultConversationTag and put it below the defaultSaveFolder below

/>
<TextComponent
name="Default Conversation Tag"
description="The default tag to be used when saving a conversation. Default is 'ai-conversations'"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where you set the default ai-conversations though, it's in constants.ts

@logancyang
Copy link
Owner

Thanks for the PR. Added some comments.

@logicsec
Copy link
Contributor Author

Fixing these now. Should have it shortly.

@logicsec
Copy link
Contributor Author

Updated. I think for now, 1 tag should be ok. In the future, we should take a look at ability to do tag lookups and allow for multi-select.

@logancyang logancyang merged commit db93a55 into logancyang:master Sep 19, 2024
@logancyang logancyang mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants