Added ability to tag saved conversations #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logancyang
reviewed
Sep 19, 2024
src/settings/SettingsPage.tsx
Outdated
| @@ -22,6 +22,7 @@ export interface CopilotSettings { | |||
| googleApiKey: string; | |||
| openRouterAiApiKey: string; | |||
| defaultModelKey: string; | |||
| defaultTag: string; | |||
There was a problem hiding this comment.
How about defaultConversationTag and put it below the defaultSaveFolder below
logancyang
reviewed
Sep 19, 2024
| @@ -79,6 +79,13 @@ const GeneralSettings: React.FC<GeneralSettingsProps> = ({ | |||
| value={settings.defaultSaveFolder} | |||
| onChange={(value) => updateSettings({ defaultSaveFolder: value })} | |||
| /> | |||
| <TextComponent | |||
| name="Default Conversation Tag" | |||
| description="The default tag to be used when saving a conversation. Default is 'ai-conversations'" | |||
There was a problem hiding this comment.
I don't see where you set the default ai-conversations though, it's in constants.ts
|
Thanks for the PR. Added some comments. |
|
Fixing these now. Should have it shortly. |
|
Updated. I think for now, 1 tag should be ok. In the future, we should take a look at ability to do tag lookups and allow for multi-select. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds the ability to tag conversations within Obsidian Copilot, allowing for easier referencing and analysis using Dataview.
Motivation:
Currently, Obsidian Copilot doesn't offer a way to tag conversations, making it difficult to organize and retrieve specific conversations for analysis using Dataview.
This feature would enable users to:
Changes: