Skip to content

Commit

Permalink
remove redundant to_dict
Browse files Browse the repository at this point in the history
  • Loading branch information
bubriks committed Jan 10, 2025
1 parent c4b76e7 commit 134e6a3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion python/hsfs/core/deltastreamer_jobconf.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(
if isinstance(spark_options, JobConfiguration):
self._spark_options = spark_options
elif isinstance(spark_options, dict):
self._spark_options = JobConfiguration(**spark_options if spark_options else {}).to_dict()
self._spark_options = JobConfiguration(**spark_options if spark_options else {})

def to_dict(self):
return {
Expand Down
2 changes: 1 addition & 1 deletion python/hsfs/core/ingestion_job_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(
if isinstance(spark_job_configuration, JobConfiguration):
self._spark_job_configuration = spark_job_configuration
elif isinstance(spark_job_configuration, dict):
self._spark_job_configuration = JobConfiguration(**spark_job_configuration if spark_job_configuration else {}).to_dict()
self._spark_job_configuration = JobConfiguration(**spark_job_configuration if spark_job_configuration else {})

@property
def data_format(self):
Expand Down
2 changes: 1 addition & 1 deletion python/hsfs/core/training_dataset_job_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def __init__(
if isinstance(spark_job_configuration, JobConfiguration):
self._spark_job_configuration = spark_job_configuration
elif isinstance(spark_job_configuration, dict):
self._spark_job_configuration = JobConfiguration(**spark_job_configuration if spark_job_configuration else {}).to_dict()
self._spark_job_configuration = JobConfiguration(**spark_job_configuration if spark_job_configuration else {})

@property
def query(self):
Expand Down

0 comments on commit 134e6a3

Please sign in to comment.