Do not catch exception

logicalclocks · Jul 10, 2024 · 3186e1a · 3186e1a
1 parent 4bf3396
commit 3186e1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/java/spark/src/main/java/com/logicalclocks/hsfs/spark/engine/SparkEngine.java b/java/spark/src/main/java/com/logicalclocks/hsfs/spark/engine/SparkEngine.java
@@ -1100,11 +1100,7 @@ protected String makeQueryName(String queryName, FeatureGroupBase featureGroup)
 
   public void closeSparkSession() {
     if (getSparkSession() != null) {
-      try {
-        getSparkSession().stop();
-      } catch (Exception e) {
-        // No-OP
-      }
+      getSparkSession().stop();
     }
   }
 }
diff --git a/utils/python/hsfs_utils.py b/utils/python/hsfs_utils.py
@@ -294,7 +294,4 @@ def parse_isoformat_date(da: str) -> datetime:
         run_feature_monitoring(job_conf)
 
     if spark is not None:
-        try:
-            spark.stop()
-        except Exception as e:
-            pass
+        spark.stop()