fix inplace

logicalclocks · Jul 9, 2024 · fb6642d · fb6642d
1 parent 16e40f7
commit fb6642d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/python/hsfs/engine/python.py b/python/hsfs/engine/python.py
@@ -1196,7 +1196,7 @@ def _apply_transformation_function(
             str, transformation_function_attached.TransformationFunctionAttached
         ],
         dataset: Union[pd.DataFrame, pl.DataFrame],
-        inplace=False,
+        inplace=True,
     ) -> Union[pd.DataFrame, pl.DataFrame]:
         for (
             feature_name,
@@ -1205,15 +1205,15 @@ def _apply_transformation_function(
             if isinstance(dataset, pl.DataFrame) or isinstance(
                 dataset, pl.dataframe.frame.DataFrame
             ):
-                if inplace:
+                if not inplace:
                     dataset = dataset.clone()
                 dataset = dataset.with_columns(
                     pl.col(feature_name).map_elements(
                         transformation_fn.transformation_fn
                     )
                 )
             else:
-                if inplace:
+                if not inplace:
                     dataset = pd.DataFrame.copy(dataset)
                 dataset[feature_name] = dataset[feature_name].map(
                     transformation_fn.transformation_fn