Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1181][APPEND] for materialized training datasets check helper column name clashes only on creation phase #1231

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

davitbzh
Copy link
Contributor

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

python/hsfs/core/feature_view_engine.py Outdated Show resolved Hide resolved
python/hsfs/core/feature_view_engine.py Outdated Show resolved Hide resolved
f"Provided feature {f_name} is ambiguous and exists in more than one feature groups."
"To avoid this error specify prefix in the join."
)
def _check_if_exists_with_prefix(self, f_name, f_set, check_prefix):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding check_prefix to this method just means that the check should not be done, you can on the other hand skip calling this method..

@davitbzh davitbzh requested a review from kennethmhc February 20, 2024 12:10
@davitbzh
Copy link
Contributor Author

Thanks @kennethmhc, good comments. Refactored and tests are passing

Copy link
Contributor

@kennethmhc kennethmhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davitbzh davitbzh merged commit 6907101 into logicalclocks:master Feb 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants