Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1411-APPEND] On-Demand Transformations #244

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

manu-sj
Copy link
Contributor

@manu-sj manu-sj commented Jul 25, 2024

This PR fixes a bug introduced by the PR logicalclocks/feature-store-api#1371

Issue - Transformation function read from feature store directly using the get_transformation_function causing a exception in the backend because the column transformation_function_argument_names is not set.

Root Cause - Issue caused by transformation_function_argument_names not being set in from_response_json. This cause transformation function read from the backend to not the transformation_function_argument_names which in turn causes the DTO to not have it.

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@manu-sj manu-sj requested a review from robzor92 July 25, 2024 13:20
@manu-sj manu-sj merged commit 85105f5 into logicalclocks:main Jul 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants