[HWORKS-2117] Make rondb-helm works for RonDB 24.10

[KernelMaker]

No description provided.

[Copilot]

Pull Request Overview

This PR updates the rondb-helm chart to support RonDB 24.10 by upgrading image tags, updating the command-line configuration, and bumping version numbers.

• Updated image tags in values.yaml for both rondb and toolbox.
• Changed the command from "rdrs" to "rdrs2" in templates/rdrs.yaml and removed GRPC port configurations.
• Bumped Chart version and appVersion in Chart.yaml.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
values.yaml	Updated image tags to target RonDB 24.10 and toolbox tag to 0.8.
templates/rdrs.yaml	Updated command configuration and removed GRPC ports.
Chart.yaml	Updated chart and application version numbers.

Files not reviewed (1)

• files/configs/rest_api.json: Language not supported

Comments suppressed due to low confidence (2)

templates/rdrs.yaml:59

• Please confirm that the change from 'rdrs' to 'rdrs2' is intentional. If this update is not correct, it could lead to command execution errors.

rdrs2 --config {{ include "rondb.dataDir" $ }}/rest_api.json

templates/rdrs.yaml:152

• The removal of GRPC port definitions might affect services relying on GRPC endpoints. Please verify that this omission is an intentional part of the RonDB 24.10 update.

-    - name: grpc

[maismail]

A general comment, are we planning to create a branch for rondb-helm to be based on 22.10 since i assume we might need to do some fixes in the future for 4.2 which uses the rondb-helm chart 0.6.5 . If so, i think we should adapt the version of the rondb-helm chart to reflect that as well @kouzant @KernelMaker

[KernelMaker]

I discussed with Antonios last week, and the conclusion was that there will be a standalone branch for 22.10 in the future. The default branch will serve as the main development branch for 24.10 going forward.

We haven’t finalized when or where exactly to create the new branch for 22.10 yet, but I assume it should start from the last commit before this patch is merged? @kouzant @maismail

[kouzant]

Yeah exactly. As @KernelMaker said we'll create the 0.6 branch. We waited until Serverless migration in case we had to do some changes so we don't need to backport

[maismail]

Ok, make sense, thanks!

[KernelMaker]

Rebased onto the latest main(commit id:bba23141a86dc66000ea38869608477c9a77a345), which now includes updates from the 0.6 branch

[kouzant]

@KernelMaker the latest commit introduced a TargetGroupBinding for rdrs-grpc Could you please remove that block?

[kouzant]

Also, it looks like something is wrong with the datanodes https://github.com/logicalclocks/rondb-helm/actions/runs/14337188971

[KernelMaker]

Added one more commit:

Author: KernelMaker [email protected]
Date: Fri Apr 11 14:20:04 2025 +0200

[HWORKS-2117] Make rondb-helm works for RonDB 24.10 [PATCH 2]
1. Archive error and trace logs if `ndbmtds.sh` detects them on restart
2. Remove GRPC from `rdrs-aws-TargetGroupBinding.yaml`

[kouzant]

Is there a common suffix we can filter tracefiles? I'm thinking of your comment in case we/somebody adds more files under log directory. If not, then that's good enough

[KernelMaker]

Here are the log file names I got from the test env:
ndb_4_error.log, ndb_4_trace.log.1, ndb_4_trace.log.1_t1, ndb_4_trace.log.2, ndb_4_trace.log.2_t1, ndb_4_trace.log.3, ndb_4_trace.log.3_t1, ndb_4_trace.log.4, ndb_4_trace.log.4_t1, ndb_4_trace.log.next

They don’t have a common suffix.. maybe ndb_*log*

[kouzant]

Yeah I think filter just the logs is safer, in case something else accidentally ends in this directory

[KernelMaker]

[HWORKS-2117] Make rondb-helm work with RonDB 24.10 [PATCH 3]

Update regex from ndb_* to ndb*_log* for safer archiving of trace and error logs.