Skip to content

Conversation

@jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Jan 29, 2026

This way we can avoid rebuilding Nim every time we build packages.

Compilation of libwaku with Nim: 9 minutes
Compilation of libwaku without Nim: 5 minutes

Notably this upgrades from Nim 2.2.4 to 2.2.8.

Depends on:

@jakubgs jakubgs requested a review from a team January 29, 2026 12:36
@jakubgs jakubgs self-assigned this Jan 29, 2026
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3703

Built from a75a8e3

Copy link
Contributor

@markoburcul markoburcul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more readable, great job. Shame that libwaku-android-arm64 can't be built, but that is not impacted by this pr:

logos-messaging-nim> Hint:  [Link]
logos-messaging-nim> ld: error: unable to find library -lrln
logos-messaging-nim> clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
logos-messaging-nim> Error: execution of an external program failed: '/nix/store/hjyfpc9vzbd54fdzhv34c89bqy18s82s-androidsdk-mod-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang  @libwaku_linkerArgs.txt'

@jakubgs jakubgs force-pushed the nix/use-nbs-flake branch 3 times, most recently from fba0b90 to e0cc2f0 Compare January 29, 2026 17:35
This way we can avoid rebuilding Nim every time we build packages.

Compilation of `libwaku` with Nim: 9 minutes
Compilation of `libwaku` without Nim: 5 minutes

Notably this upgrades from Nim 2.2.4 to 2.2.8.

Depends on:
status-im/nimbus-build-system#112

Signed-off-by: Jakub Sokołowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants