- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 54
feat(solid): add solid.js logto sdk #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@yefu24324 you may need to run |
export const baseUrl = window.location.origin; | ||
export const redirectUrl = `${baseUrl}/callback`; | ||
|
||
export const appId = 'hi9w1eijf2nlnuz88xjt6'; // Register the sample app in Logto dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can replace them with env variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just consts with fake ID, like in the other samples. Not a big deal, though.
export default function Callback() { | ||
const navigate = useNavigate(); | ||
const { isLoading } = useHandleSignInCallback(() => { | ||
console.log("???") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to replace with more friendly message or delete it.
Hey @yefu24324, thank you for your contribution. We're really excited to see your PR. While we are reviewing the code, could you please also complete the steps to sign your commits? You can follow the GitHub official guide and let us know if you have questions. |
Okay, I need to learn GPG, |
Summary
add solid.js logto sdk
Testing
Local preview.
Checklist
.changeset
I referenced React and rewrote the SDK for SolidJS. Please let me know if there are any issues with the code