refactor: split Angular utilities into a dedicated package #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangsijie
force-pushed
the
wangsijie-log-11489-remove-angular-from-js-package
branch
2 times, most recently
from
1e53fd0 to
829ce48
Compare
charIeszhao
reviewed
May 13, 2025
charIeszhao
reviewed
May 13, 2025
charIeszhao
approved these changes
May 13, 2025
wangsijie
force-pushed
the
wangsijie-log-11489-remove-angular-from-js-package
branch
from
829ce48 to
09cd6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #956
Summary
The original Angular utilities required Angular-specific type annotations. They have been removed from
@logto/jsand moved to a dedicated package to resolve import issues when using@logto/js.Testing
Local tested.
Checklist
.changeset