-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to API contract usage #1111
Conversation
pathResolver: () => '/users', | ||
description: 'Create user', | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilya-levin-lokalise Does storing contract next to controller/route make sense to you, or you would put them into separate files, e. g. contract closer to schemas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is not a question for me, so sorry for jumping in 😓
Just to share my 2 cents, in my opinion, and ideally, we will have a package with the client for the service, and the schemas and API contracts should live there so we make sure both are always in sync. Wondering if we should prepare the template with that structure 🤔. Although, this can be done in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I think you are right, we should optimize for the use-case of reusing the contract outside of the service, so it makes sense if the initial structure is built around that idea. thanks, I'll adjust the code
No description provided.