Bump the vitest group with 2 updates #766
Conversation
dependabot
bot
requested review from
a team,
CarlosGamero,
dariacm and
kibertoad
as code owners
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vitest-0717ef0daf
branch
2 times, most recently
from
48b9635 to
1649022
Compare
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
DevDependency updatespackages/app/api-common/package.json, packages/app/api-contracts/package.json, packages/app/auth/package.json, packages/app/aws-config/package.json, packages/app/backend-http-client/package.json, packages/app/background-jobs-common/package.json, packages/app/context-fastify-plugins/package.json, packages/app/error-utils/package.json, packages/app/fastify-api-contracts/package.json, packages/app/fastify-bullboard-plugin/package.json, packages/app/frontend-http-client/package.json, packages/app/healthcheck-utils/package.json, packages/app/id-utils/package.json, packages/app/metrics-utils/package.json, packages/app/non-translatable-markup/package.json, packages/app/prisma-utils/package.json, packages/app/script-utils/package.json, packages/app/supported-languages/package.json, packages/app/universal-testing-utils/package.json, packages/app/universal-ts-utils/package.json, packages/app/websockets-common/package.json, packages/app/zod-extras/package.json |
Updated devDependencies: vitest and/or @vitest/coverage-v8 bumped from 3.x → 4.0.8. No other dependency, script, source code, or public API changes detected. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
- Homogeneous manifest edits across many packages (same devDeps bumped to 4.0.8).
- Areas to double-check:
- Test suite compatibility with Vitest 4.0.8 (API/behavior, test runner flags, mocking).
- Coverage reporter/integration changes for
@vitest/coverage-v8v4.0.8 and CI configuration.
Pre-merge checks and finishing touches
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description lacks required template sections: 'Changes' section is missing, and the checklist items ('major'/'patch' label, documentation updates, test updates) are not properly completed. | Complete the PR description template by adding a 'Changes' section describing the updates and ensuring all checklist items are properly addressed or marked as N/A. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title 'Bump the vitest group with 2 updates' accurately summarizes the main change, which is updating vitest and @vitest/coverage-v8 dependencies across 20 package.json files. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
dependabot/npm_and_yarn/vitest-0717ef0daf
📜 Recent review details
Configuration used: Repository: lokalise/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (22)
packages/app/api-common/package.json(1 hunks)packages/app/api-contracts/package.json(1 hunks)packages/app/auth/package.json(1 hunks)packages/app/aws-config/package.json(1 hunks)packages/app/backend-http-client/package.json(1 hunks)packages/app/background-jobs-common/package.json(1 hunks)packages/app/context-fastify-plugins/package.json(1 hunks)packages/app/error-utils/package.json(1 hunks)packages/app/fastify-api-contracts/package.json(1 hunks)packages/app/fastify-bullboard-plugin/package.json(2 hunks)packages/app/frontend-http-client/package.json(1 hunks)packages/app/healthcheck-utils/package.json(1 hunks)packages/app/id-utils/package.json(1 hunks)packages/app/metrics-utils/package.json(1 hunks)packages/app/non-translatable-markup/package.json(1 hunks)packages/app/prisma-utils/package.json(1 hunks)packages/app/script-utils/package.json(1 hunks)packages/app/supported-languages/package.json(1 hunks)packages/app/universal-testing-utils/package.json(1 hunks)packages/app/universal-ts-utils/package.json(1 hunks)packages/app/websockets-common/package.json(1 hunks)packages/app/zod-extras/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (11)
- packages/app/universal-ts-utils/package.json
- packages/app/auth/package.json
- packages/app/context-fastify-plugins/package.json
- packages/app/error-utils/package.json
- packages/app/api-common/package.json
- packages/app/background-jobs-common/package.json
- packages/app/fastify-bullboard-plugin/package.json
- packages/app/prisma-utils/package.json
- packages/app/websockets-common/package.json
- packages/app/fastify-api-contracts/package.json
- packages/app/zod-extras/package.json
🔇 Additional comments (4)
packages/app/script-utils/package.json (1)
40-40: I need to verify the actual requirements and breaking changes for Vitest 4.0.I need to search for more specific information about Vitest 4.0's Node version requirement.
Based on my verification, I found a critical inaccuracy in the original review comment:
Correct the Node version requirement claim
Vitest 4.0 supports Node "^18.0.0 || >=20.0.0", meaning Node 18 is still supported. The claim that "Vitest requires... Node >=v20.0.0" is incorrect. Additionally, Vitest 4.0 removed support for Vite 5, so Vite 6+ is now required.
Regarding the constructor mocking breaking change and other warnings mentioned: The codebase uses
vi.spyOn()on instance methods (e.g.,vi.spyOn(job, 'clearLogs')), which are not affected by the constructor mocking change that requires either function or class keywords. No vitest config files, custom reporters, or snapshot files with custom elements were found in the codebase.Likely an incorrect or invalid review comment.
packages/app/non-translatable-markup/package.json (1)
37-37: ---Verify test compatibility with vitest v4.0.8 locally.
Test execution in the sandbox environment failed due to build infrastructure issues (Rollup parsing error) before vitest could run, preventing verification. Run
npm run test:cilocally to confirm the test suite is compatible with the v4.0.8 upgrade.Also applies to: 40-40
packages/app/healthcheck-utils/package.json (1)
52-52: Verification inconclusive due to sandbox limitations; manual testing with Docker required.The npm install succeeded with peer dependency warnings (which are expected and handled), but the test:ci command failed because Docker is not available in this sandbox environment. The esbuild error is an artifact of the sandbox and not indicative of real issues.
To properly verify the vitest v4.0.8 upgrade in this package, you must run the tests in an environment with Docker support:
cd packages/app/healthcheck-utils npm install npm run test:ciConfirm that both the Docker-based Redis setup and test suite execute successfully.
packages/app/aws-config/package.json (1)
64-64: Verify test execution results with vitest 4.0.8 manually.The test installation and execution command were initiated, but the output was truncated before showing pass/fail results. Additionally, multiple npm package resolution warnings occurred during installation. While vitest 4.0.8 was successfully resolved, we cannot definitively confirm that the test suite passes with this version.
Manual verification required:
- Run the full test suite in
packages/app/aws-configand confirm all tests pass with vitest 4.0.8- Check for any test failures or breaking changes related to the major version bump
- Verify that
--typecheckand--coverageflags execute without errorsNo standard vitest configuration file was found, indicating the package uses default settings or inherits configuration from a parent workspace configuration.
Comment @coderabbitai help to get the list of available commands and usage tips.
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vitest-0717ef0daf
branch
2 times, most recently
from
18ea32f to
ed95d14
Compare
Bumps the vitest group with 2 updates: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@vitest/coverage-v8` from 3.2.4 to 4.0.3 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.3/packages/coverage-v8) Updates `vitest` from 3.2.4 to 4.0.3 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.3/packages/vitest) --- updated-dependencies: - dependency-name: "@vitest/coverage-v8" dependency-version: 4.0.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: vitest - dependency-name: vitest dependency-version: 4.0.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: vitest ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/vitest-0717ef0daf
branch
from
ed95d14 to
20c92fa
Compare
Bumps the vitest group with 2 updates: @vitest/coverage-v8 and vitest.
Updates
@vitest/coverage-v8from 3.2.4 to 4.0.3Release notes
Sourced from
@vitest/coverage-v8's releases.... (truncated)
Commits
ca1766fchore: release v4.0.307bc56achore: release v4.0.24a28faachore: release v4.0.1da7ce17chore: release v4.0.03e4b6b7chore: release v4.0.0-beta.1935816fefix(coverage): v8 to ignore Vite's generated cjs import helpers (#8718)bc7c20dchore: release v4.0.0-beta.184783137chore: release v4.0.0-beta.176fc7890chore: release v4.0.0-beta.16d677c0bchore: release v4.0.0-beta.15Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@vitest/coverage-v8since your current version.Updates
vitestfrom 3.2.4 to 4.0.3Release notes
Sourced from vitest's releases.
... (truncated)
Commits
ca1766fchore: release v4.0.3155521afix: preserve reporter options from config when CLI reporters override them (...abc046ffix(init): use correct jsx/tsx extension (#8792)0fb74bdfix(happy-dom): support fetch globals (#8791)07bc56achore: release v4.0.22eedbcefix(spy): reset spies if bothrestoreMocksandmockResetis set in the co...26ce88dfix(pool): assign envs before running tests to keep in sync with process.env ...4a28faachore: release v4.0.13fae73efix(pool): don't teardown the communication channel too soon if something is ...8100063fix: move thegetBuiltinscheck (#8765)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for vitest since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by CodeRabbit