Skip to content

Conversation

@JakkuSakura
Copy link
Contributor

This is a continuation of #764
Without this, if we drag webview to sidebar and collapse, webview is not aware of itself being hidden
image

@huacnlee
Copy link
Member

huacnlee commented Apr 2, 2025

You don't have to follow up and insert the WebView into the Panel. This will cause many problems, WebView used into GPUI there have a lot of limit.

Actually in our application, we only use WebView to render into a Drawer or a Modal.

@huacnlee
Copy link
Member

huacnlee commented Apr 2, 2025

And I also removed WebView story in PR #769 from the main example application, because if we enable this, the WebView will cause some unexpected problems (For example: It will get the focus handle in high priority, this will break the general element's events).

@JakkuSakura
Copy link
Contributor Author

JakkuSakura commented Apr 2, 2025

I see. This PR is clean though. It doesn't add WebView anywhere. It just fixes the relevant issue

@huacnlee
Copy link
Member

huacnlee commented Apr 2, 2025

I have done a test, this change is not correct. When I collapse a bottom dock, the log is display like:

panel: Image active: true
panel: Icon active: true
panel: Image active: false
panel: Icon active: false
panel: Image active: true
panel: Icon active: true
panel: Tooltip active: true

@JakkuSakura
Copy link
Contributor Author

What should be the correct output?

@huacnlee
Copy link
Member

huacnlee commented Apr 2, 2025

You can test it, the log is unexpected.

@JakkuSakura
Copy link
Contributor Author

Ah I see. Fixed now

@huacnlee huacnlee changed the title feat: implement set_active method for panel management dock: Fix to sync active state to panels when collapse dock. Apr 3, 2025
@huacnlee
Copy link
Member

huacnlee commented Apr 3, 2025

Thanks.

@huacnlee huacnlee merged commit 3051b9c into longbridge:main Apr 3, 2025
1 check passed
@JakkuSakura JakkuSakura deleted the fix-panel branch April 5, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants