fix determining the response body tag name #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Doronin <[email protected]>
|
Same is here https://github.com/vpulim/node-soap/blob/master/src/client.ts#L341 |
|
@underoll, sorry about the delay in reviewing your PR. There are test failures caused by your change. Could you please take a look if you're still interested in pursuing? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like
outputBodyDescriptor.elements[0].qname.namewill never work, because it takes one level deeper then needed.If it has the reason, i'd propose to return
obj.Bodyas the result in case it is still empty after the three guesses.Checklist
guide