feature/ability to apply coupon for price #2
Conversation
…emove confictable require 'pry'
… to MonopayRuby.configuration , add ability to make discount
lib/monopay-ruby/configuration.rb
Outdated
| attr_accessor :api_token, :min_value | ||
|
|
||
| def initialize | ||
| @api_token = ENV["MONOBANK_API_TOKEN"] # note ability to use ENV variable in docs |
There was a problem hiding this comment.
можеш цей комент забрати і буду просити створити розділ Configuration в рідмі, також вкажи там, що можна передати такий параметер і яке значення по дефолту та яке мінімальне, також дай рейз, якщо задане значення меньше мінімального, щось типу Configuration value error: minimal allowed value is 0.01, your is "0"
| elsif amount.is_a?(Integer) | ||
| amount | ||
| else | ||
| raise TypeError, "expected amount will be an Integer or BigDecimal, got #{amount.class}" |
There was a problem hiding this comment.
або allowed to use only a BigDecimal or Integer price
README.md
Outdated
| ``` | ||
| * 0.01 UAH - it is a minimal valid value for Monobank: | ||
| - if you use 1 as an Integer it is equal to 0.01 UAH | ||
| - if you use BigDeciamal(5) it's equal to 5 UAH |
There was a problem hiding this comment.
чому не 1? давай теж 1, щоб було зрозуміло різницю
README.md
Outdated
| ```ruby | ||
| # config/initializers/monopay-ruby.rb | ||
| MonopayRuby.configure do |config| | ||
| config.min_value = 1 |
There was a problem hiding this comment.
краще не min_value, а min_price
README.md
Outdated
| Where: | ||
| - discount - is an number, which represents a % of discount if discount_is_fixed: false and an amount of discount if discount_is_fixed: true | ||
| - discount_is_fixed - a Boolean which set type of discount: | ||
| - ```true``` if it's with fixed amount, for example a coupon | ||
| - ```false``` if you need a some percentage of discount | ||
| * can be Integer, Float or BigDecimal |
There was a problem hiding this comment.
Options:
discount - ..
discount_is_fixed - with false (default) means that discount amount will be preceded by %. When true used, means fixed amount of discount will be applied
| # @param [String] reference - bill number or other reference | ||
| # @return [Boolean] true if invoice was created successfully, false otherwise | ||
| def create(amount, destination: nil, reference: nil) | ||
| def create(amount, discount=nil, discount_is_fixed=false, destination: nil, reference: nil) |
There was a problem hiding this comment.
нє, ну це ж кпц), юзай неймед параметри
| # @param [String] reference - bill number or other reference | ||
| # @return [Boolean] true if invoice was created successfully, false otherwise | ||
| def create(amount, destination: nil, reference: nil) | ||
| def create(amount, discount: nil, discount_is_fixed: false, destination: nil, reference: nil) |
There was a problem hiding this comment.
щось трохи забагато аргументів, по конвеншинам так краще не робити, ну передавати можна, але от явно прописаних вже забагато, макс 3 гуд є, чи близько того
Added: