default Registration Strategy bug

loresoft · Dec 5, 2023 · 201658b · 201658b
1 parent 980da4e
commit 201658b
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/src/Injectio.Generators/ServiceRegistrationGenerator.cs b/src/Injectio.Generators/ServiceRegistrationGenerator.cs
@@ -305,7 +305,7 @@ private static (IReadOnlyCollection<Diagnostic> diagnostics, bool hasServiceColl
             && implementationType == null
             && serviceTypes.Count == 0)
         {
-            registrationStrategy = KnownTypes.RegistrationStrategyImplementedInterfacesShortName;
+            registrationStrategy = KnownTypes.RegistrationStrategySelfWithInterfacesShortName;
         }
 
         // no implementation type set, use class attribute is on

diff --git a/...s/ServiceRegistrationGeneratorTests.GenerateRegisterScopedSelfWithInterfaces.verified.txt b/...s/ServiceRegistrationGeneratorTests.GenerateRegisterScopedSelfWithInterfaces.verified.txt
@@ -27,6 +27,14 @@ namespace Microsoft.Extensions.DependencyInjection
                 )
             );
 
+            global::Microsoft.Extensions.DependencyInjection.Extensions.ServiceCollectionDescriptorExtensions.TryAdd(
+                serviceCollection,
+                global::Microsoft.Extensions.DependencyInjection.ServiceDescriptor.Describe(
+                    typeof(global::Injectio.Sample.SingletonService),
+                    typeof(global::Injectio.Sample.SingletonService), 
+                    global::Microsoft.Extensions.DependencyInjection.ServiceLifetime.Scoped
+                )
+            );
             return serviceCollection;
         }
     }

diff --git a/...ts/Snapshots/ServiceRegistrationGeneratorTests.GenerateRegisterSingletonTags.verified.txt b/...ts/Snapshots/ServiceRegistrationGeneratorTests.GenerateRegisterSingletonTags.verified.txt
@@ -29,6 +29,14 @@ namespace Microsoft.Extensions.DependencyInjection
                     )
                 );
 
+                global::Microsoft.Extensions.DependencyInjection.Extensions.ServiceCollectionDescriptorExtensions.TryAdd(
+                    serviceCollection,
+                    global::Microsoft.Extensions.DependencyInjection.ServiceDescriptor.Describe(
+                        typeof(global::Injectio.Sample.ServiceTag),
+                        typeof(global::Injectio.Sample.ServiceTag), 
+                        global::Microsoft.Extensions.DependencyInjection.ServiceLifetime.Singleton
+                    )
+                );
             }
 
             return serviceCollection;

diff --git a/...erviceRegistrationGeneratorTests.GenerateRegisterTransientSelfWithInterfaces.verified.txt b/...erviceRegistrationGeneratorTests.GenerateRegisterTransientSelfWithInterfaces.verified.txt
@@ -27,6 +27,14 @@ namespace Microsoft.Extensions.DependencyInjection
                 )
             );
 
+            global::Microsoft.Extensions.DependencyInjection.Extensions.ServiceCollectionDescriptorExtensions.TryAdd(
+                serviceCollection,
+                global::Microsoft.Extensions.DependencyInjection.ServiceDescriptor.Describe(
+                    typeof(global::Injectio.Sample.SingletonService),
+                    typeof(global::Injectio.Sample.SingletonService), 
+                    global::Microsoft.Extensions.DependencyInjection.ServiceLifetime.Transient
+                )
+            );
             return serviceCollection;
         }
     }