Skip to content

Update barrier generation #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

GMart
Copy link
Contributor

@GMart GMart commented May 30, 2025

Fix typo with building floor variations color map, and add oak trapdoor block
Update barrier generation: Separate out ways and nodes. Add gates and stiles, etc as nodes.
Update metal and related barriers to IRON_BARS

GMart added 3 commits May 29, 2025 18:56
Fix type with building floor variations color map, and add oak trapdoor block
Update barrier generation: Separate out ways and nodes. Add gates and stiles, etc as nodes.
Update metal and related barriers to IRON_BARS
@GMart GMart marked this pull request as ready for review May 30, 2025 22:16
@GMart
Copy link
Contributor Author

GMart commented May 30, 2025

retrigger-benchmark
Edit: There seems to be a bug with the benchmark that is failing the first time you start a PR, every time. The Action doesn't have access to leave a comment to start itself, even though it ran just fine.

Copy link

⏱️ Benchmark run finished in 0m 39s
🧠 Peak memory usage: 1612 MB

📈 Compared against baseline: 42s
🧮 Delta: -3s
🔢 Commit: 101b340

🟢 Generation time is unchanged.

You can retrigger the benchmark by commenting retrigger-benchmark.

@GMart
Copy link
Contributor Author

GMart commented May 31, 2025

Gates currently show up like this with hedges and other barriers, not sure why. I think the barrier way is processed after the node.
2025-05-30_20 38 08
There should be air above the trapdoor.

Add additional whitelist items to gate nodes, to hopefully improve the look of gates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant