-
-
Notifications
You must be signed in to change notification settings - Fork 578
Replace editor with Codemirror #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
If anyone wants to be able to use this now, I have a fork with a docker image at andersmmg/dockge. Just replace |
Hi, this is awesome work...I have a fork as well but just merge several PRs I find useful. I tried to merge yours but unfortunately I am not very familiar with VUE.js to get your PR to work nicely with the global environment PR I merged. |
…e-editor Merged @andersmmg's pull request replacing the editor with codemirror.
Merge @andersmmg's pull request replacing the editor with codemirror.
Merged @andersmmg's pull request that replaces the prism editor with codemirror.
@andersmmg any idea how to setup / use the default themes? I'm really not a fan of the bright green dracula uses but I can't get anything other then the theme from thememirror to work. Codemirror has a whole theme tester https://codemirror.net/5/demo/theme.html and they are all listed here https://codemirror.net/5/theme/ . I was hoping to use the moxer one. |
@Dracrius I was able to use most of the themes available for the latest codemirror, I can see if I can get that theme working later when I have time. I would think it should be as simple as importing it and setting the theme Edit: looks like moxer isn't listed in the themes for codemirror 6, it might just not have been ported to the latest version but I'll see when I can |
Ah silly me I should have realized the 5 in the url meant they were for codemirror 5. I appreciate the help. That theme, a github dark or vscode dark theme would all work if moxer was never ported. |
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
Replaces the prism editor with codemirror. Fixes several annoyances I've had. Uses Python highlighting for .env because it works well and doesn't really matter much. Mostly did this for myself but hopefully it can benefit others as well.
Fixes #105, #530 and related editor issues.
Type of change
Checklist
(including JSDoc for methods)
Screenshots