Skip to content

Conversation

maca134
Copy link

@maca134 maca134 commented May 15, 2025

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Small change to make the stack list UI easier to use when using multiple agents.

Type of change

  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

Both agents open:
c02fFOsqbSOtahQ3zWd0

One agent collapsed:
PbTUuEKanPtlJxeM6DrZ

@maca134 maca134 marked this pull request as ready for review May 15, 2025 07:39
Dracrius added a commit to Dracrius/dockge that referenced this pull request Jun 2, 2025
Merged @maca134's pull request that improves the stack list ui when using agents.
Dracrius added a commit to Dracrius/dockge that referenced this pull request Jun 3, 2025
Merged @maca134's pull request that improves stacks list ui when using agents.
@Dracrius
Copy link

Dracrius commented Jun 4, 2025

@maca134 sorry to bother you but any chance you'd be willing to refactor this to use endpointdisplay in StackList.vue similar to StackListItem.vue where you display the url of agents with the dropdown? Currently it uses agent.endpoint which will only display the url. endpointdisplay on the other hand especially when combined with #414 and friendly names displays the name first or the url if it has no name.

This appears to be the more intended way to get the "label" for an agent as it already existed before friendly nanes and was updated to accomodate.

I attempted half a dozen ways myself but I've also been working 12hr days. I think I'm just making a logical error since it should have been simple but anything I try ends up with a blank name tag for anything other then current.

@maca134
Copy link
Author

maca134 commented Jun 4, 2025

I will have a look but I have to admit this was the first time I have ever done anything in Vue.

@cmcooper1980
Copy link

I will have a look but I have to admit this was the first time I have ever done anything in Vue.

That is further than my understanding LOL...I know just enough to make minor fixes. I have a fork where I merged several what seems like useful PRs and I just tried to merge yours but there are conflicts in my StackList.vue. Anyways, it is probably somewhat related to what @Dracrius mentions since I do have #414 merged as well. Anyways, once I think I resolved it the entire list in the left pane goes missing.

@jearton
Copy link

jearton commented Jun 5, 2025

I really want this feature.

Dracrius added a commit to Dracrius/dockge that referenced this pull request Jun 5, 2025
@Dracrius
Copy link

Dracrius commented Jun 5, 2025

Finally fixed. I personally also prefer to keep the sub title of the agent if it isn't on the current. Seems silly but with longer lists if the agent title is scrolled off screen it improves readability. Might be worth adding a setting for before @louislam gets backs. There will be an impressive number of pulls for 1.6.0 and I think this is far cleaner then #593 but adding agent labels as a setting would really polish off this PR.

image

@GamerClassN7 GamerClassN7 mentioned this pull request Aug 7, 2025
7 tasks
@NATroutter
Copy link

This really needs to be added. It's so messy to manage multiple projects across multiple agents on Dockge. This would be absolutely god-tier to have.

@cmcooper1980
Copy link

merged to my fork along with @Dracrius QOL tweak commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants