-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fixing recurring maintenance start (again) #5914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing recurring maintenance start (again) #5914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good.
I am a bit concearend, that the check if the interval is enough produces differently incorrect results.
Hi @CommanderStorm! Any other change needed before merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🎉
and sorry that this required a ping, I am a bit behind on thigns |
No problem @CommanderStorm, it's normal not being available all the time. |
📋 Overview
Provide a clear summary of the purpose and scope of this pull request:
What problem does this pull request address?
🔄 Changes
🛠️ Type of change
🔗 Related Issues
📄 Checklist *
ℹ️ Additional Context
Provide any relevant details to assist reviewers in understanding the changes.
Click here for more details:
Key Considerations:
After some discussions in #5903, I submit my solution avoiding intervals. This should make maintenance starting at the right moment, and at least, avoid any kind of drift.