Skip to content

Fixing recurring maintenance start (again) #5914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2025

Conversation

Ionys320
Copy link
Contributor

📋 Overview

Provide a clear summary of the purpose and scope of this pull request:

🔄 Changes

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)

🔗 Related Issues

📄 Checklist *

  • 🔍 My code adheres to the style guidelines of this project.
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

ℹ️ Additional Context

Provide any relevant details to assist reviewers in understanding the changes.

Click here for more details:

Key Considerations:

After some discussions in #5903, I submit my solution avoiding intervals. This should make maintenance starting at the right moment, and at least, avoid any kind of drift.

@louislam louislam added this to the 2.0.0-beta.4 milestone Jun 14, 2025
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good.
I am a bit concearend, that the check if the interval is enough produces differently incorrect results.

@Ionys320 Ionys320 requested a review from CommanderStorm June 19, 2025 09:39
@Ionys320
Copy link
Contributor Author

Hi @CommanderStorm! Any other change needed before merge?

@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label Jul 16, 2025
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎉

@CommanderStorm CommanderStorm merged commit 7c88a38 into louislam:master Jul 16, 2025
19 checks passed
@CommanderStorm
Copy link
Collaborator

and sorry that this required a ping, I am a bit behind on thigns

@Ionys320
Copy link
Contributor Author

No problem @CommanderStorm, it's normal not being available all the time.

@Ionys320 Ionys320 deleted the fix/maintenance_drift branch July 16, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:needs review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled maintenance starts one minute later every day
3 participants