-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: Add heartbeat tooltip while hovering over status page heartbeats #5929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add heartbeat tooltip while hovering over status page heartbeats #5929
Conversation
IMPORTANT: |
I love the designs. Good work 👏 Will review this and the other PR on Wednesday. I am currently struggling though writing a paper for a university-seminar. |
thanks man I'm glad you like it and good luck on the paper, no stress at all :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
I like the design work 👍🏻
I talked to one of my designer friends (🦖, @twihno) and they really like it too..
src/components/HeartbeatBar.vue
Outdated
> | ||
<div | ||
class="beat" | ||
:class="{ 'empty': (beat === 0), 'down': (beat.status === 0), 'pending': (beat.status === 2), 'maintenance': (beat.status === 3) }" | ||
:class="{ 'empty': (beat === 0 || beat === null || beat.status === null), 'down': (beat.status === 0), 'pending': (beat.status === 2), 'maintenance': (beat.status === 3) }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on discussion in other pr might need to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah keeping it open for the moment until the other one is reviewed
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Super cool thanks guys for the review and UX suggestions! Will take a look at all of it soon :) |
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review should be ready for review again :)
src/components/HeartbeatBar.vue
Outdated
> | ||
<div | ||
class="beat" | ||
:class="{ 'empty': (beat === 0), 'down': (beat.status === 0), 'pending': (beat.status === 2), 'maintenance': (beat.status === 3) }" | ||
:class="{ 'empty': (beat === 0 || beat === null || beat.status === null), 'down': (beat.status === 0), 'pending': (beat.status === 2), 'maintenance': (beat.status === 3) }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah keeping it open for the moment until the other one is reviewed
@peaktwilight given that I think the consensus in #5916 is that that needs another testing round, where exactly is this bugging out? I did not find anything and would merge this one first otherwise if this is outdated. |
I've just tested with the latest version and a fresh db and I believe that it's no longer dependent on the other merge and should work without the other one getting merged first :D |
good work and thanks for debugging it. |
This PR introduces a really nice and sleek tooltip component that comes up on hover (and we can use it in other places because it's a standalone vue component)
Important
It kind of builds upon the changes made in #5916 otherwise it bugs out in the time mgmt.
So merge that before looking into this please.
DEMO:



🔄 Changes
🛠️ Type of change
🔗 Related Issues
📄 Checklist *