-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Domain expiry notifications #6098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems solid, nice work.
I have noted a few things below, but nothing structural.
Sorry to split this review into two parts, I am reviewing this from a beach in Italy 🏖️
db/knex_migrations/2025-09-02-0000-add-domain-expiry-notification.js
Outdated
Show resolved
Hide resolved
|
d0ac65d
to
f854ec5
Compare
…ion.js Co-authored-by: Frank Elsinga <[email protected]>
Btw who are the maintainers of Uptime Kuma ? i.e. who is able to give my PR a review ? |
I and louis. https://github.com/louislam/uptime-kuma/issues?q=state%3Aopen%20label%3A%22pr%3Aneeds%20review%22 |
📋 Overview
I used RDAP APIs to get the expiry date. This worked for most of the domains I tested, but I am aware that not absolutely all domains supports this for now.
Domains lookups are saved in a database, and are checked one time a day.
If the option is activated for multiple URLs on the same domain, only one lookup a day will be done, and only one notification will be sent.
Technical questions
Currently, the table domain_expiry_info is never emptied. Maybe some sort of cleanup could be added, how can I implement this ?
Maybe "clear all entries not checked for 2 days", because it means the check isn't active anymore.
Also, I currently fetch the RDAP list at every check (https://data.iana.org/rdap/dns.json). So this is "1 time a day * number of domains monitored". Do you think some sort of cache should be added for this ?
I would like to avert user if the TLD is not supported (no RDAP in the json), but I don't really now how to achieve this.
I currently added a WARN in the console if not RDAP server is found.
🛠️ Type of change
📄 Checklist
📷 Screenshots or Visual Changes
Domain Name Expiry Notification option for http monitor
Domain expiry notify days settings
Domain expiry stat on overview
Domain expiry notification