Skip to content

Conversation

lucthienphong1120
Copy link

❗ Important Announcements

Click here for more details:

⚠️ Please Note: We do not accept all types of pull requests, and we want to ensure we don’t waste your time. Before submitting, make sure you have read our pull request guidelines: Pull Request Rules

🚫 Please Avoid Unnecessary Pinging of Maintainers

We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.

📋 Overview

  • This PR introduces configurable database connection pool settings for MariaDB/MySQL in Uptime Kuma.
    • This helps improve stability in large deployments without requiring a fork or manual patch.
  • Updated server/database.js to use these variables when initializing Knex connection for MariaDB/MySQL.
    • Prevents Timeout acquiring a connection issues in high-traffic or large-scale setups.

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality)
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

📄 Checklist

  • 🔍 My code adheres to the style guidelines of this project.
  • 🦿 I have indicated where (if any) I used an LLM for the contributions
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).
Event Before After
UP Before After
DOWN Before After
Certificate-expiry Before After
Testing Before After

@lucthienphong1120 lucthienphong1120 changed the title Fix: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call? #2346 Fix: Knex: Timeout acquiring a connection. The pool is probably full. #2346 Sep 25, 2025
@lucthienphong1120 lucthienphong1120 changed the title Fix: Knex: Timeout acquiring a connection. The pool is probably full. #2346 Fix: Knex: Timeout acquiring a connection. The pool is probably full. Sep 25, 2025
@CommanderStorm
Copy link
Collaborator

Are you still experiencing this on v2.0?

@CommanderStorm CommanderStorm added the question Further information is requested label Sep 25, 2025
@CommanderStorm CommanderStorm marked this pull request as draft September 25, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace: KnexTimeoutError: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call?

2 participants