chore: refactor by removing a couple variables #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@styfle No problem, same overall performance, could be a bit slower because of |
H4ad
approved these changes
Jul 18, 2023
lovell
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Given the following:
- we're thinking about micro-optimisations
- we only need to check for the string literal
"GLIBC"in all capitals (or the string literal"musl"in all lower case) - the length of
/usr/bin/lddfile on the latest Ubuntu is 5390 bytes
how about these changes?
Co-authored-by: Lovell Fuller <[email protected]>
styfle
commented
Jul 19, 2023
Co-authored-by: Steven <[email protected]>
lovell
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up due to comment #19 (comment)
See related PR: