-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erode / dilate preliminary implementation #4243
Conversation
Merci beaucoup for the PR Quentin, I'll try to take a look to see if I can work out why the erode operation is not working as expected. |
This will be fixed via PR libvips/libvips#4240. Thanks for reporting this! |
Is there progress on this? upstream pr is already merged |
@faradaytrs This is dependent on the future libvips v8.16.1. Please subscribe for updates. |
seems like it has been released |
The @qpincon If you're still interested and available to help with this PR please can you rebase and test, thank you. |
Rebased and landed via commit 031c808 - merci beaucoup Quentin! |
Thank you, sorry for not responding earlier! |
Adresses #1719.
This is mostly a copy / paste of the previous try of implementation by #1744
The
dilate
operation works well, howevererode
does not seem to work but rather just shift the whole black pixels to the bottom right. I really can't tell why. I tried to fill the mask with 0, 128 and 255, but the results are the same.If anyone has an idea as of why it happens, I'll gladly try to fix it!