Skip to content

Remove redundant TIFF warning handler setup #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

kleisauke
Copy link
Contributor

This became redundant after commit libvips/libvips@22994d9.

@lovell
Copy link
Owner

lovell commented Jul 10, 2025

I was planning to leave this logic in place for a bit longer as some OS and package managers for which prebuilt binaries are not provided e.g. FreeBSD still provide libvips v8.17.0.

@kleisauke
Copy link
Contributor Author

Isn't that an invalid use case? See for example:

sharp/src/common.h

Lines 17 to 21 in 276ac2d

#if (VIPS_MAJOR_VERSION < 8) || \
(VIPS_MAJOR_VERSION == 8 && VIPS_MINOR_VERSION < 17) || \
(VIPS_MAJOR_VERSION == 8 && VIPS_MINOR_VERSION == 17 && VIPS_MICRO_VERSION < 1)
#error "libvips version 8.17.1+ is required - please see https://sharp.pixelplumbing.com/install"
#endif

In other words, you can't compile sharp v0.34.3 with libvips v8.17.0.

@lovell
Copy link
Owner

lovell commented Jul 10, 2025

Ha ha, oh yeah, I try to be an angel to FreeBSD's demon but look what happens! 😅

@lovell lovell merged commit 6cde18d into lovell:main Jul 10, 2025
29 checks passed
@kleisauke kleisauke deleted the remove-vips2tiff-log-handler branch July 10, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants