Conversation
pamaury
reviewed
Oct 7, 2024
pamaury
reviewed
Oct 7, 2024
pamaury
reviewed
Oct 7, 2024
pamaury
approved these changes
Oct 7, 2024
pamaury
left a comment
pamaury
left a comment
There was a problem hiding this comment.
This looks ok to me but I don't know enough about the details of namespaces to give some detailed feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default Docker/k8s run the root user inside the container as the root user of the host. This means that there's syscall filtering and path masking necessary to prevent the root of inside container from escaping. This negatively affects Nix sandboxing inside containers, because syscalls it rely on are blocked.
User namespaces also the root user inside a container to be mapped to a non-root user -- this would make all filtering and masking unnecessary (and is what rootless containers use). When we enable userns, we can then disable filtering/masking without compromising security, and then enable Nix sandbox.