Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added surfer waveviewer package #29

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Added surfer waveviewer package #29

merged 1 commit into from
Apr 5, 2024

Conversation

HU90m
Copy link
Member

@HU90m HU90m commented Apr 5, 2024 

# This doesn't work, it fails to load the libraries
nix run .#surfer

# But this does work
nix build .#surfer
nix develop .#surfer
./result/bin/surfer

I think it may be something to do with winit using dlopen and LD_LIBRARY_PATH, but can't figure it out.

@nbdd0121 nbdd0121 marked this pull request as ready for review April 5, 2024 10:50
hcallahan-lowrisc
hcallahan-lowrisc approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@hcallahan-lowrisc hcallahan-lowrisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix run github:HU90m/lowrisc-nix?ref=surfer#surfer seems to launch and run correctly, so LGTM!

nbdd0121
nbdd0121 reviewed Apr 5, 2024
View reviewed changes
pkgs/surfer.nix Outdated Show resolved Hide resolved
pkgs/surfer.nix Outdated Show resolved Hide resolved
@HU90m
Copy link
Member Author

HU90m commented Apr 5, 2024

nix run github:HU90m/lowrisc-nix?ref=surfer#surfer seems to launch and run correctly, so LGTM!

Yes, Gary kindly fixed it

@HU90m HU90m requested a review from nbdd0121 April 5, 2024 13:06
@nbdd0121 nbdd0121 merged commit f703a25 into lowRISC:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcallahan-lowrisc hcallahan-lowrisc hcallahan-lowrisc approved these changes

@nbdd0121 nbdd0121 nbdd0121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HU90m @nbdd0121 @hcallahan-lowrisc