Added PeakRDL package and it's dependencies #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we want to add all dependencies to flake packages output. If you want to expose them you can make dependencies of |
nbdd0121
reviewed
Jun 8, 2024
pkgs/peakrdl.nix
Outdated
| inherit description; | ||
| homepage = "https://github.com/SystemRDL/${name}"; | ||
| license = lib.licenses.gpl3; | ||
| mainProgram = name; |
There was a problem hiding this comment.
This probably isn't correct for non-binary packages.
HU90m
force-pushed
the
peakrdl
branch
2 times, most recently
from
1b2ce5a
to
e1cf9e8
Compare
|
pkgs/default.nix conflicts with veridian |
nbdd0121
reviewed
Sep 30, 2024
pkgs/peakrdl.nix
Outdated
| license = lib.licenses.gpl3; | ||
| }; | ||
| }; | ||
| in rec { |
There was a problem hiding this comment.
It looks like this in rec { can be removed, and have in peakrdl added to the very end?
pkgs/peakrdl.nix
Outdated
| # Copyright lowRISC Contributors. | ||
| # SPDX-License-Identifier: MIT | ||
| {pkgs}: let | ||
| inherit (pkgs) python3Packages fetchFromGitHub lib; |
There was a problem hiding this comment.
These can be part of parameters if you use callPackage.
nbdd0121
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to have a play:
nix run .#peakrdl -- --helpFYI: @jwnrt